From Surf Wiki (app.surf) — the open knowledge base
When You're Smiling
| Field | Value |
|---|---|
| name | When You're Smiling |
| cover | When You're Smiling (1928) Sheet Music.pdf |
| caption | Sheet music, 1928 |
| published | 1928 by Mills Music |
| writer | Larry Shay, Mark Fisher, Joe Goodwin |
"When You're Smiling" is a popular song written by Larry Shay, Mark Fisher and Joe Goodwin. First published in 1928, popular recordings were made by Seger Ellis (1928), Louis Armstrong (1929), and Ted Wallace & His Campus Boys (1930).
The lyrics and music of the song entered the public domain in the United States in 2024.
It is the unofficial anthem of Leicester City Football Club, adopted by fans in the 1980s. As of 2022, the recording by Jersey Budd is played before the start of each home match.
Other notable recordings

- Cliff Bruner's Texas Wanderers – recorded September 13, 1938, it reached the country charts in 1939. This version was sung by singer pianist Moon Mullican.
- Louis Armstrong – Satchmo: A Musical Autobiography (1956). In his recording from 1929, Armstrong tried to adapt the "white" style of Guy Lombardo through the inclusion of an expansive saxophone section sound.
References
References
- (1986). "Joel Whitburn's Pop Memories 1890-1954". Record Research Inc.
- "Public Domain Day 2024 {{!}} Duke University School of Law".
- "When You're Smiling {{!}} Leicester City".
- "The Online Discographical Project".
- Brothers, Thomas. (2014). "Louis Armstrong: Master of Modernism". W.W. Norton & Company.
This article was imported from Wikipedia and is available under the Creative Commons Attribution-ShareAlike 4.0 License. Content has been adapted to SurfDoc format. Original contributors can be found on the article history page.
Ask Mako anything about When You're Smiling — get instant answers, deeper analysis, and related topics.
Research with MakoFree with your Surf account
Create a free account to save articles, ask Mako questions, and organize your research.
Sign up freeThis content may have been generated or modified by AI. CloudSurf Software LLC is not responsible for the accuracy, completeness, or reliability of AI-generated content. Always verify important information from primary sources.
Report